Tabs javascript

by Megi93

HTML

<div class="tabs-box">
	<nav>
		<ul>
			<li class="active"><a href="#tab-1">1 Nunc tincidunt</a></li>
			<li><a href="#tab-2">2 Proin dolor</a></li>
			<li><a href="#tab-3">3 Aenean lacinia</a></li>
		</ul>
	</nav>
	<div id="tab-1">
		<p>1 Proin elit arcu, rutrum commodo, vehicula tempus, commodo a, risus. Curabitur nec arcu. Donec sollicitudin mi sit amet mauris. Nam elementum quam ullamcorper ante. Etiam aliquet massa et lorem. Mauris dapibus lacus auctor risus. Aenean tempor ullamcorper leo. Vivamus sed magna quis ligula eleifend adipiscing. Duis orci. Aliquam sodales tortor vitae ipsum. Aliquam nulla. Duis aliquam molestie erat. Ut et mauris vel pede varius sollicitudin. Sed ut dolor nec orci tincidunt interdum. Phasellus ipsum. Nunc tristique tempus lectus.</p>
	</div>
	<div id="tab-2">
		<p>2 Morbi tincidunt, dui sit amet facilisis feugiat, odio metus gravida ante, ut pharetra massa metus id nunc. Duis scelerisque molestie turpis. Sed fringilla, massa eget luctus malesuada, metus eros molestie lectus, ut tempus eros massa ut dolor. Aenean aliquet fringilla sem. Suspendisse sed ligula in ligula suscipit aliquam. Praesent in eros vestibulum mi adipiscing adipiscing. Morbi facilisis. Curabitur ornare consequat nunc. Aenean vel metus. Ut posuere viverra nulla. Aliquam erat volutpat. Pellentesque convallis. Maecenas feugiat, tellus pellentesque pretium posuere, felis lorem euismod felis, eu ornare leo nisi vel felis. Mauris consectetur tortor et purus.</p>
	</div>
	<div id="tab-3">
		<p>3 Mauris eleifend est et turpis. Duis id erat. Suspendisse potenti. Aliquam vulputate, pede vel vehicula accumsan, mi neque rutrum erat, eu congue orci lorem eget lorem. Vestibulum non ante. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Fusce sodales. Quisque eu urna vel enim commodo pellentesque. Praesent eu risus hendrerit ligula tempus pretium. Curabitur lorem enim, pretium nec, feugiat nec, luctus a, lacus.</p>
		<p>Duis cursus....

CSS

.tabs-box {
	padding: 15px;
	border: 1px solid #AFAFAF;
}

.tabs-box nav ul {
	list-style: none;
	padding: 0;
	margin: 0;
}

.tabs-box nav ul li {
	position: relative;
	border-top: 1px solid lime;
	border-right: 1px solid lime;
	border-left: 1px solid lime;
	display: inline-block;
	z-index: 2;
}

.tabs-box nav ul li.active {
	background-color: orange;
	border-bottom: 1px solid transparent;
}

.tabs-box nav ul li a {
	padding: 10px;
	display: inline-block;
}

.tabs-box div[id*=tab-] {
	position: relative;
	top: -1px;
	padding: 0 15px;
	border: 1px solid lime;
	z-index: 1;
}

.tabs-box div[id*=tab-] ~ div[id*=tab-] {
	display: none;
}

JavaScript

"use strict"; // Never write code without this directive.
var Test = {};
// lower case tabs as it is no longer created with the new token
// It represents a tab not a group of tabs
Test.tab = function (tabBox) { // renamed argument from element to tabBox
	var tabs, i; // variables to the top
	function tabClick(event) {
		if (event.ctrlKey || event.metaKey) {
			return;
		}
		event.preventDefault();
		event.stopPropagation();
		// href returns full path so split at the # and get the last item
		toggle("#" + this.href
			   .split("#")
			   .pop()
			  );
	}
	function toggle(ref) {
		var targets, i; // declare variables at top of function
		targets = tabBox.querySelectorAll('[id*=tab-]');
		for (i = 0; i < targets.length; i++) {
			targets[i].style.display = 'none';  // would it not be better that
			// this be a CSS rule rather than
			// an inline style
		}
		// readability when chaining functions indent and separate into 
		// lines to make it easy to read
		tabBox
			.querySelector('.active') // Why use querySelectorAll. querySelector is more efficient
			.classList
			.remove('active');
		tabBox
			.querySelector('[href="' + ref + '"]')
			.parentNode
			.classList
			.add('active');
		tabBox
			.querySelector(ref)
			.style
			.display = 'block';  // should be a CSS rule not inline
	}
	// no need for the following to be in a function
	tabs = tabBox.querySelectorAll('nav ul li a');
	for (i = 0; i < tabs.length; i++) {
		// don't declare functions inside loops. tabClick is now a named function
		tabs[i].addEventListener('click', tabClick, false);
	}
};

// no need for immediate invocation
Array.prototype.forEach.call(
	document.querySelectorAll('.tabs-box'),
	Test.tab  // no need for anon function pass referance directly
);